Nathan Bubna wrote:
I hadn't thought about this before, but i think you're right that
using the word component everywhere is unnecessary, as it is implicit
and everything is still clear to me without it. more specific
comments below...
On 3/20/07, Antonio Petrelli <[EMAIL PROTECTED]> wrote:
Hi all!
I know that the subject line is a bit cryptic, but I will try to
explain it.
Currently Tiles codebase refers to a lot of "Component" classes:
ComponentDefinition, ComponentDefinitions, ComponentDefinitionsImpl,
ComponentAttribute, ComponentContext, ComponentConstants,
ComponentContextMutator.
I hope that I did not forget anyone :-)
Now the question is: what is the concept of a "component"? Is it
simply a remnant from the Struts-Tiles code?
I think that these classes should be renamed, but I think that a bit
of brainstorming is needed.
+1
Here are my suggestions:
ComponentDefinition - Definition
ComponentDefinitions - DefinitionGroup (help me, I did not find a
better name :-)
+1
sorry, nothing better comes to mind yet.
ComponentDefinitionsImpl - DefinitionGroupImpl
ComponentAttribute - Attribute
ComponentContext - TilesRenderContext (because it is used during
rendering Tiles pieces).
i'd prefer AttributeContext, as that's what it contains.
+1, I prefer AttributeContext as well.
ComponentConstants - Globals
why not just Constants? i'd prefer to keep it closer to the original,
to minimize confusion.
+1 for Constants.
ComponentContextMutator - TilesRenderContextMutator.
AttributeContextMutator
+1
David
Let's improve this list, or give a reason for "Component" concept to
exist.
TIA
Antonio
