On Sat, Jan 16, 2010 at 11:42 AM, Antonio Petrelli <[email protected]> wrote: > 2010/1/16 Nathan Bubna <[email protected]>: >>> Note that the VelocityStyleTilesTool is ok, since it is a *real* tool: >>> http://tiles.apache.org/framework/apidocs/org/apache/tiles/velocity/template/VelocityStyleTilesTool.html >> >> yep. even if it's API is a bit verbose. ;) > > Why verbose? It's got only 11 methods and 0 or 1 parameter. What are > you referring to?
the method names, not the size or complexity of the API. specifically, 9 of 11 methods include the word 'Attribute'. Personally, i would leave that to be implied, especially with things like renderAttribute(Attribute) or cloneAttribute(Attribute) where it is clearly redundant, and shrinking getAttribute(String) to get(String) would enable the much cleaner $tiles.myAttrKey syntax. granted, the explicitness of the current method names offers extra mental clarity/simplicity. i know enough people who prefer that to short and/or overloaded method names, that i'm not dogmatic. i just can't help making comments sometimes. :) >>> IMHO the best thing to do is to delete it, though we released a beta >>> version of the 2.2 series. >> >> i have no love for it. but beta is not alpha. can we deprecate for a >> version and delete in the subsequent one? > > Sure, it will be deleted in 3.0 > > Thanks > Antonio >
