On 12-02-21 09:30 AM, Mick Semb Wever wrote:
Nick: i believe this follows what you explained/wanted?
Yes it does. I just would have moved a step further and removed the ReflexionContextResolver and Request.getNativeScopes(), now unreferenced. IMHO these are more confusing than useful.
I also notice that you've replaced the arrays (String[]) with Collections (List<String>). I have no objection to it, but we didn't discuss it so far. Do you believe we should avoid using arrays in APIs?
I didn't test it much either, but the changes are pretty straightforward and the selenium tests are unchanged and still working (well, the ones that used to). So I believe we didn't break anything, at least for servlets and templates (I believe selenium does not test portlets).
Nick
