On 12-02-21 05:35 PM, Nicolas LE BAS wrote:
Hi,

Please have a look at https://github.com/nlebas/tiles/tree/resource.
It is quite a large changeset. These URL things were everywhere :(
39 files changed, 1522 insertions(+), 1491 deletions(-)

I think the overall result is a simplified code base, but more complex
unit tests, mostly because DefinitionDAO must now include a reference to
ApplicationContext. But I think encapsulating all the URL rewriting code
for the Locales is worth an extra reference to a singleton.

Thanks,
Nick

I've tested it a bit and fixed a design issue with checked exceptions. Now I'm satisfied with it and I'll commit it to trunk, unless you have comments.

Thanks,
Nick

Reply via email to