[
https://issues.apache.org/jira/browse/TINKERPOP-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300494#comment-15300494
]
Marko A. Rodriguez commented on TINKERPOP-1312:
-----------------------------------------------
This is a really good idea. If benchmarking shows it to be more efficient, than
do it. I suspect it will be given 1) less steps 2) no reducing barrier 3)
{{hasNext()}}. In terms of where to put it, just put it in
{{RangeByIsCountStrategy}} as well...yea...but don't make a new strategy and
don't rename {{RangeByIsCountStrategy}} for backwards compatible reasons.
However, for 3.3.0, we could do a rename to {{CountStrategy}}.
> .is.count(0) is not properly optimized
> --------------------------------------
>
> Key: TINKERPOP-1312
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1312
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.2.0-incubating, 3.1.2-incubating
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
> Fix For: 3.1.3, 3.2.1
>
>
> {{bla.count().is(0)}} gets optimized by {{RangeByIsCountStrategy}}, which
> replaces it with {{bla.limit(1).count().is(0)}}. That's good, but we can do
> even better by replacing it with {{__.not(bla)}}, which is a simple
> {{.hasNext()}} instead of a {{RangeStep}} followed by a
> {{ReducingBarrierStep}} ({{count()}}).
> Question is: should we do the replacement in {{RangeByIsCountStrategy}}? The
> strategy will recognize the pattern, no matter if we use it for the
> replacement or not; it's just that the strategy name is then no longer in
> line with the the actual replacement (for this particular {{.count().is(0)}}
> case) as it won't inject a {{RangeStep}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
