[ 
https://issues.apache.org/jira/browse/TINKERPOP-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300837#comment-15300837
 ] 

ASF GitHub Bot commented on TINKERPOP-1310:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/319

    TINKERPOP-1310: Allow OLAP to return properties as Detached

    https://issues.apache.org/jira/browse/TINKERPOP-1310
    
    I created {{HaltedTraverserFactoryStrategy}} which is an OLAP strategy that 
can return {{DetachedXXX}} elements to the user instead of always just the 
plain (data-less) {{ReferenceXXX}}. Also did lots of nick nack optimizations 
and documentation to {{TraversalVertexProgram}}.
    
    CHANGELOG
    ```
    * Added `HaltedTraverserFactoryStrategy` to allow users to get back 
different element detachments in OLAP.
    ```
    
    VOTE +1. (Giraph still running)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1310

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #319
    
----
commit b72ea666ce18920a8dd7d1d4c30bbe029fe4ae80
Author: Marko A. Rodriguez <[email protected]>
Date:   2016-05-24T22:50:19Z

    TraversalVertexProgram can use DetachFactory or ReferenceFactory when 
sending halted traversers to the master traversal. The default is to use 
ReferenceFactory (more efficient), but if someone wants to use DeatchedFactory, 
then they do 
g.withComputer().withStrategies(HaltedTraverserFactoryStrategy.detached()). 
Easy peasy lemon squeezy. Still need to write specific test cases, but manual 
testing shows things workings.

commit 19f16f1c6a9954a30fc2031df34724e56b2124fc
Author: Marko A. Rodriguez <[email protected]>
Date:   2016-05-25T14:42:51Z

    minor tweak. need to work in another branch.

commit 3978e7bda5f4896ea1c2815c889e206afcbaccaa
Author: Marko A. Rodriguez <[email protected]>
Date:   2016-05-25T18:25:31Z

    lots of documentation on TraversalVertexProgram and got 
HaltedTraveserFactoryStrategy tested and optimized.

commit 7255844c03fc1b6d447a2631250100758c4f84cb
Author: Marko A. Rodriguez <[email protected]>
Date:   2016-05-25T18:25:51Z

    Merge branch 'master' into TINKERPOP-1310

commit e6f2caa89adc8e6630dadc613ca9b6b92416c223
Author: Marko A. Rodriguez <[email protected]>
Date:   2016-05-25T20:54:15Z

    lots of more documentation on TraversalVertexProgram and I really combed 
through the code and was able to find numerous minor optimizations here and 
there.

----


> Allow OLAP to return properties as Detached
> -------------------------------------------
>
>                 Key: TINKERPOP-1310
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1310
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.0-incubating
>            Reporter: stephen mallette
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.2.1
>
>
> Make it possible for an OLAP TraversalSource to have graph elements be 
> returned with properties. Currently they return a "reference" vertex (which 
> excludes all properties), but should have the option to be returned as a 
> "detached" vertex (which includes all properties)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to