Github user dkuppitz commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/320#discussion_r64829983
  
    --- Diff: 
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/RangeByIsCountStrategyTest.java
 ---
    @@ -142,6 +142,7 @@ public void doTest(final Traversal traversal, final 
Traversal optimized) {
                         {__.out().count().is(without(2, 6, 4)), 
__.out().limit(6).count().is(without(2, 6, 4))},
                         {__.map(__.count().is(0)), 
__.map(__.limit(1).count().is(0))},
                         {__.flatMap(__.count().is(0)), 
__.flatMap(__.limit(1).count().is(0))},
    +                    {__.filter(__.count().is(0)), 
__.filter(__.not(__.identity()))},
    --- End diff --
    
    It is the same, but IMO it's not RangeByIsCountStrategy's job to optimize 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to