[
https://issues.apache.org/jira/browse/TINKERPOP-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313025#comment-15313025
]
ASF GitHub Bot commented on TINKERPOP-1322:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/326
TINKERPOP-1322 Added ConfigurationCustomizerCompiler
https://issues.apache.org/jira/browse/TINKERPOP-1322
This `CustomizerCompiler` implementation makes it possible to set low-level
configurations in the `GremlinGroovyScriptEngine` on the Groovy
`CompilerConfiguration` which ultimately controls script compilation settings
used by the classloader. The most likely feature that someone would use here is
the setting of the `ScriptBaseClass` which will let executing scripts inherit
some base functionality.
All good with:
```text
mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false
```
Also performed a manual test with Gremlin Server that worked nicely.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1322
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #326
----
commit e32347c13e6c4917ebc691aa70e8531cb6b36e1a
Author: Stephen Mallette <[email protected]>
Date: 2016-06-02T20:39:51Z
Added ConfigurationCustomizerCompiler
This CustomizerCompiler implementation makes it possible to set low-level
configurations in the GremlinGroovyScriptEngine on the Groovy
CompilerConfiguration which ultimately controls script compilation settings
used by the classloader.
----
> Provide fine-grained control of CompilerConfiguration
> -----------------------------------------------------
>
> Key: TINKERPOP-1322
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1322
> Project: TinkerPop
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.2.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.2.1
>
>
> It would be nice if all aspects of the {{GremlinGroovyScriptEngine}} were
> configurable via the {{CompilerConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
