Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/335#discussion_r67163346
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/FeatureSupportTest.java
---
@@ -587,7 +587,7 @@ public void
shouldSupportRemoveEdgesIfEdgeCanBeRemoved() throws Exception {
public void shouldSupportRemovePropertyIfAPropertyCanBeRemoved()
throws Exception {
try {
final Vertex v = graph.addVertex();
- final Edge e = v.addEdge("self", v);
+ final Edge e = v.addEdge("self", v, "name", "foo");
--- End diff --
In all your thinking on this PR, did you ever think of any way to "test our
tests" for proper feature assignments? perhaps that's a bit advanced and
impossible a thing to do, but anything else we could do to make this process of
adding features less error prone? or do we just need to rely on good code
reviews of tests to be sure features go in the right way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
