[
https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333826#comment-15333826
]
ASF GitHub Bot commented on TINKERPOP-1320:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/336
I didn't re-test this but both travis builds are good and the code looks
right. Just a side note - @pluradj I didn't review this but note that we have a
bit of an ugly reality where `TestHelper` has a twin over in
`gremlin-core/test`. There are test classes in there that need that kind of
functionality and since `gremlin-core` can't depend on `gremlin-test` I just
copied the file. :grimacing: Note sure if any of your changes needs to be
propagated over there or not, but probably something you should look at before
you finalize this one and merge. Pending that little investigation:
VOTE +1
> GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
> ------------------------------------------------------------------------------
>
> Key: TINKERPOP-1320
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1320
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.2.0-incubating, 3.1.2-incubating
> Reporter: Jason Plurad
> Assignee: Jason Plurad
> Priority: Minor
> Fix For: 3.1.3, 3.2.1
>
>
> This is similar to TINKERPOP-1317. The differences here are
> * The {{TestHelper.generateTempFileFromResource()}} call to load the resource
> is happening from the {{public static void init()}} method before a graph
> instance is available.
> * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still
> required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
