GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/339

    TINKERPOP-939 Added docs for Neo4j HA configuration.

    https://issues.apache.org/jira/browse/TINKERPOP-939
    
    I manually tested this with a local 3 node cluster both in Gremlin Console 
and in Gremlin Server. Everything seems to work fine. I basically just wrote 
some basic docs for how to setup but since TinkerPop is really just a pass 
through for configuration options, most of the docs for "how" are on the Neo4j 
side.
    
    I don't know that there is a way to do testing for this on our current 
framework or if there is a ton of value to doing so as this is all pass through 
- we don't even use a separate "HA Graph instance" like we did in Blueprints. 
Thoughts welcome on that matter....
    
    Personally, I think the docs are enough for now to close this old issue. If 
we really want tests we could open a new issue to write some "integration" 
tests that do some basic checks and would stand apart from the standard 
framework. So based on that....
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-939

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #339
    
----
commit 6220653868fc0c00a397456f9b7cceae82c3cb4a
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-06-16T15:54:02Z

    Added docs for Neo4j HA configuration.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to