Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/342#discussion_r67417561
--- Diff:
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java
---
@@ -358,6 +350,14 @@ public Features features() {
return features;
}
+ private void validateHomogenousIds(final List<Object> ids) {
+ final Class firstClass = ids.get(0).getClass();
+ for (Object id : ids) {
+ if (!id.getClass().equals(firstClass))
+ throw Graph.Exceptions.idArgsMustBeEitherIdOrElement();
+ }
+ }
+
--- End diff --
cool - i will integrate - nice find. might also add a test for null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
