Validate distribution looks good along with manual inspection of docs and testing. Thanks for putting this all together Stephen and for running me through part of the process this time.
VOTE: +1 --Ted On Wed, Jul 20, 2016 at 3:42 PM, Stephen Mallette <spmalle...@gmail.com> wrote: > Thanks Hadrian - I read that section you referenced to remind myself of how > Apache viewed the -1 and I understood it as you described, however I went > so far as to say a "-1 means aborting the release" because as the release > manager I was taking the the non-binding -1 pretty seriously with the > likely action of killing the release if Pieter's concern wasn't cleared. > anyway - glad to see that we worked through our first -1 on VOTE day for a > release ;) > > On Wed, Jul 20, 2016 at 4:24 PM, Hadrian Zbarcea <hzbar...@gmail.com> > wrote: > > > +1 > > > > Stephen, a -1 on a release is not a veto, see the "votes on package > > releases" section on the foundation site [1]. It is up to the release > > manager to decide how to proceed. Usually releases are redone not because > > of the -1, but because there is a valid reason behind the -1. Experienced > > committers and contributors understand if a -1 is warranted and weird -1s > > are rare. It is also my preference (and that's what I did in the past) to > > cancel releases even based on non-binding -1s, because the voice of > > contributors matters too. > > > > Pretty cool that dialogue led to consensus and actions on how to make > > progress. Another proof of how awesome the Tinkerpop community is. > > > > Cheers, > > Hadrian > > > > > > On 07/20/2016 12:01 PM, Stephen Mallette wrote: > > > >> Pieter, Thanks as usual for testing. I would offer than this is not a > case > >> for a -1. Note that a -1 says we abort the release completely. > >> > >> imo, a -1 should be reserved for when there is a massive bug that brings > >> down the house - meaning the system is abend in some way and there are > no > >> workarounds. a -1 might also be presented if the packaging is bad > somehow > >> - > >> like we didn't include the documentation in the zips. i could also see a > >> -1 > >> if somehow a GPL'd dependency snuck into our packaging somehow or we > >> otherwise violated Apache licensing. If other's don't agree, I hope > >> they'll > >> say so. > >> > >> in this case, you have a single backend for Sqlg that is failing a > single > >> test that you can temporarily OptOut of for your tests to pass. Users > >> don't > >> specifically have a workaround for this problem if they use Sqlg and > >> HSQLDB, but it's less of a "bug" and more of a feature that they can't > use > >> (i.e. they can't interrupt a running traversal). To me, I don't think we > >> need to stop release of TinkerPop over that narrow case. > >> > >> Would you reconsider your -1 based on that logic? > >> > >> > >> > >> On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail <pieter.mar...@gmail.com > > > >> wrote: > >> > >> Hi, > >>> > >>> Ran all Sqlg's tests and the process and structured test suites. > >>> But alas there are failures. > >>> > >>> TraversalInterruptionTest are failing on HSQLDB as the > >>> Thread.interrupt() is intercepted by them and the interrupt flag is > >>> reset. > >>> The TraversalInterruptionTest tests themselves suffers from this as its > >>> own Thread.sleep() logic resets the interrupt flag and requires special > >>> resetting. I'd say the current interrupt strategy needs rethinking. > >>> > >>> TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more, > >>> repeat followed by a tail step, tests in sqlg, all of which also fails. > >>> Jason has already proposed a fix for this here > >>> <https://issues.apache.org/jira/browse/TINKERPOP-1379>. > >>> > >>> vote -1 > >>> > >>> Thanks > >>> Pieter > >>> > >>> > >>> > >>> On 19/07/2016 15:20, Stephen Mallette wrote: > >>> > >>>> Hello, > >>>> > >>>> We are happy to announce that TinkerPop 3.2.1 is ready for release - > >>>> note > >>>> the lack of "-incubating" everywhere. :) > >>>> > >>>> The release artifacts can be found at this location: > >>>> https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/ > >>>> > >>>> The source distribution is provided by: > >>>> apache-tinkerpop-3.2.1-src.zip > >>>> > >>>> Two binary distributions are provided for user convenience: > >>>> apache-gremlin-console-3.2.1-bin.zip > >>>> apache-gremlin-server-3.2.1-bin.zip > >>>> > >>>> The GPG key used to sign the release artifacts is available at: > >>>> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > >>>> > >>>> The online docs can be found here: > >>>> http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs) > >>>> http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs) > >>>> http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc) > >>>> http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc) > >>>> > >>>> The tag in Apache Git can be found here: > >>>> > >>>> > >>>> > >>> > https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc > >>> > >>>> > >>>> The release notes are available here: > >>>> > >>>> > >>> > https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1 > >>> > >>>> > >>>> The [VOTE] will be open for the next 72 hours --- closing Friday (July > >>>> > >>> 22, > >>> > >>>> 2016) at 9:30 am EST. > >>>> > >>>> My vote is +1. > >>>> > >>>> Thank you very much, > >>>> Stephen > >>>> > >>>> > >>> > >>> > >> >
