GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/378
TINKERPOP-1397 Fix StarGraph.addEdge
See:
* old PR #372
* JIRA issue https://issues.apache.org/jira/browse/TINKERPOP-1397
As far as I can tell, GraphFilter did not exist in 3.1, and it may not even
be possible to induce the buggy traversal behavior describe in #372 (which was
all based on master / 3.2). The underlying datastructure corruption -- putting
a StarOutEdge into the `inEdges` map -- does exist on 3.1, and @okram's
`addEdge` fix applies cleanly on 3.1, but without `applyGraphFilter`, I'm not
sure it even matters for correctness on 3.1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dalaro/incubator-tinkerpop TINKERPOP-1397-tp31
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #378
----
commit 0022b7f6be25eb7d3c778b137beb6e8a7d2784ca
Author: Dan LaRocque <[email protected]>
Date: 2016-08-10T22:52:13Z
TINKERPOP-1397 Fix StarGraph.addEdge
For self-loops, StarGraph.addEdge used to put a single StarOutEdge
into both its inEdges and outEdges maps, potentially causing problems
in applyGraphFilter.
This change makes StarGraph.addEdge put the appropriate type of edge
(Star(Out/In)Edge) in the associated map. The IDs for each edge
instance are kept in agreement.
This change is @okram's, who suggested it in PR #372. I merely
reviewed it and added a couple of comments.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
