[ 
https://issues.apache.org/jira/browse/TINKERPOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428148#comment-15428148
 ] 

ASF GitHub Bot commented on TINKERPOP-1285:
-------------------------------------------

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/385
  
    We should ask ourselves if `IdentityRemovalStrategy` is really as great as 
it should be. We need to chain dozens of `identity()`s to prove that 
`IdentityRemovalStrategy` makes the traversal execution faster. This looks way 
too artificial to me. Why would anybody end up with dozens of `identity()`s?
    
    IMHO we should either:
    * deprecate the strategy and remove it completely in a later release or
    * remove it from the default strategies and only run performance tests for 
more than 5 chained `identity()`s
    
    I think I'd prefer the former as I really can't see any real use cases 
where this strategy would be advantageous.


> Gremline console does not differentiate between multi-line and single-line 
> input
> --------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1285
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1285
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: console
>    Affects Versions: 3.2.0-incubating
>            Reporter: Rocco Varela
>            Priority: Minor
>
> When entering input, say into a script variable, that extends over multiple 
> lines the gremlin console does not provide the user with any indication that 
> they are in a multi-line input mode. Here is an example.
> Notice the 'gremline>' prompts are presented within the triple-quotes.
> {code}
> gremlin> script = '''
> gremlin> line1_command
> gremlin> line2_command
> gremlin> '''
> {code}
> Ideally we would like something like this, showing the user that they are 
> still in multi-line input mode.
> {code}
> gremlin> script = '''
> ... line1_command
> ... line2_command
> ... '''
> gremlin>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to