[ 
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431108#comment-15431108
 ] 

ASF GitHub Bot commented on TINKERPOP-1274:
-------------------------------------------

Github user newkek commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/386#discussion_r75708714
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
 ---
    @@ -54,6 +54,14 @@
         public DefaultTraversalMetrics() {
         }
     
    +    // This is only a convenient constructor needed for GraphSON 
deserialization.
    +    // TODO: see if that's ok to add that.
    +    public DefaultTraversalMetrics(long totalStepDurationNs, 
List<MutableMetrics> metricsMap) {
    --- End diff --
    
    Not sure who I should ask about that, I decided to add a public constructor 
here for convenience during the deserialization, it takes the total duration, 
and a list of all the Metrics its composed of.


> GraphSON Version 2.0
> --------------------
>
>                 Key: TINKERPOP-1274
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.1.2-incubating
>            Reporter: stephen mallette
>            Priority: Minor
>             Fix For: 3.2.2
>
>
> Develop a revised version of GraphSON that provides better support for 
> non-JVM languages that consume it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to