Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/386#discussion_r75709109
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/MutableMetrics.java
---
@@ -42,6 +42,18 @@ public MutableMetrics(final String id, final String
name) {
this.name = name;
}
+ // create a MutableMetrics from an Immutable one.
+ // needed that for tests, don't know if it is worth keeping it public.
+ // TODO: see if it's ok to add this
+ public MutableMetrics(Metrics other) {
--- End diff --
Same here I added a convenience constructor that takes any kind of Metrics
and returns a `MutableMetrics`. It was convenient for tests, as I wanted to
serialize Metrics that I am sure have nested Metrics, and make sure the ser/de
works for those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
