[
https://issues.apache.org/jira/browse/TINKERPOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488921#comment-15488921
]
ASF GitHub Bot commented on TINKERPOP-1442:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/413
TINKERPOP-1442 Improved session cleanup on client close [master]
https://issues.apache.org/jira/browse/TINKERPOP-1442
see #412 for more description
All unit tests and gremlin-server integration tests are passing on this
branch.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1442-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/413.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #413
----
commit e7d63381dcc0c53999f4270f0e6b9d4a56093673
Author: Stephen Mallette <[email protected]>
Date: 2016-09-13T22:10:09Z
Improved session cleanup on client close.
While not a perfect implementation, a long run job blocking a close request
from the client will now at least get an attempt at interruption rather thant
consuming the thread indefinitely. TINKERPOP-1442
commit cd07845479c5e945683cb5e49b92a74277295e55
Author: Stephen Mallette <[email protected]>
Date: 2016-09-13T22:17:23Z
Merge branch 'TINKERPOP-1442' into TINKERPOP-1442-master
----
> Killing session should make better attempt to cleanup
> -----------------------------------------------------
>
> Key: TINKERPOP-1442
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1442
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.1.4
> Reporter: stephen mallette
> Assignee: stephen mallette
> Fix For: 3.1.5
>
>
> When a session is killed it tries to rollback transactions prior to ending
> the session. If there is a long-run script (or perhaps a queue of jobs) then
> this close job just gets added to the queue. If that rollback job never
> executes then the transaction gets orphaned.
> Graph implementations tend to have their own methods for cleaning up these
> lingering transactions, but it would be better if the shutdown could occur in
> an orderly fashion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
