[ 
https://issues.apache.org/jira/browse/TINKERPOP-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493852#comment-15493852
 ] 

ASF GitHub Bot commented on TINKERPOP-1409:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/422

    TINKERPOP-1409 Print no result line if empty.result.indicator is empty 
string.

    https://issues.apache.org/jira/browse/TINKERPOP-1409
    
    This seems like a better use of the empty string setting than to actually 
just print an empty string line.
    
    ```text
    gremlin> graph = TinkerGraph.open()
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> graph.close()
    ==>null
    gremlin> graph = TinkerGraph.open()
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> :set empty.result.indicator ""
    gremlin> graph.close()
    gremlin> 
    ```
    
    Pretty small change, but, I didn't CTR this in case someone didn't really 
like this behavior.  If there are -1s I can just kill this and close the JIRA 
currently hanging out there as I only kept it open because I saw this dangling 
issue I wanted to implement.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1409

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #422
    
----

----


> Make the "null" return in the gremlin console into something more 
> understandable
> --------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1409
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1409
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: console
>    Affects Versions: 3.2.1
>            Reporter: Jeremy Hanna
>
> A common question among new users is what is with the "null" return String in 
> the console when there is a successful execution.  An explanation is in the 
> docs now (see note at bottom of 
> http://tinkerpop.apache.org/docs/current/reference/#_mutating_the_graph 
> section) but it would be nice to avoid it or make it more immediately 
> understandable for new users.
> It's not a huge deal, but often comes up as a question from new users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to