[
https://issues.apache.org/jira/browse/TINKERPOP-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507827#comment-15507827
]
ASF GitHub Bot commented on TINKERPOP-1457:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/429
TINKERPOP-1457 Fixed Lambda serialization in bytecode for java/groovy.
https://issues.apache.org/jira/browse/TINKERPOP-1457
Standard tests using lambdas are ignored which is why we didn't catch this
in the process tests. I added a single test to `GremlinServerIntegrationTest`
to just validate that lambdas could be sent, so we at least have a basic smoke
test for that functionality.
Also opened up a few tests by removing some `OptOut` entries on
`RemoteGraph`.
All tests pass with:
```text
$ mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false
```
Going to kick off a full docker build tonight too.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1457
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #429
----
commit 6b03f61723837809c61951a516d5a8207d8d18f1
Author: Stephen Mallette <[email protected]>
Date: 2016-09-20T20:24:34Z
Fixed Lambda serialization in bytecode for java/groovy.
Standard tests using lambdas are ignored which is why we didn't catch this
in the process tests. I added a single test to GremlinServerIntegrationTest to
just validate that lambdas could be sent, so we at least have a basic smoke
test for that functionality.
commit f5ef7c13bce8f9f2b0a057c6c2c26d26a32c1e09
Author: Stephen Mallette <[email protected]>
Date: 2016-09-20T21:18:18Z
Removed some OptOuts on RemoteGraph.
More tests seem to be working now after the GraphSON 2.0 implementation.
----
> Groovy Lambdas for remote traversals not serializable
> -----------------------------------------------------
>
> Key: TINKERPOP-1457
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1457
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.2.2
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Critical
> Fix For: 3.2.3
>
>
> Basically, a request like this:
> {code}
> g.V().hasLabel('person').map(Lambda.function("it.get().value('age') + 10"))
> {code}
> won't work in 3.2.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
