[ 
https://issues.apache.org/jira/browse/TINKERPOP-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15519396#comment-15519396
 ] 

ASF GitHub Bot commented on TINKERPOP-1464:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/435

    TINKERPOP-1464 Added a Gryo serializer for Bytecode.

    https://issues.apache.org/jira/browse/TINKERPOP-1464
    
    All good with:
    
    ```text
    $ mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false
    ```
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1464

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #435
    
----
commit 66d206a098f3c68d7bfb174c50d927f1181c18ff
Author: Stephen Mallette <[email protected]>
Date:   2016-09-24T18:03:30Z

    Added a Gryo serializer for Bytecode. TINKERPOP-1464

----


> Gryo Serialization for Bytecode
> -------------------------------
>
>                 Key: TINKERPOP-1464
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1464
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.2.2
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.2.3
>
>
> {{Bytecode}} will serialize over gryo currently, but it does so by using 
> GraphSON under the covers. That approach was a bit of cheat to stay on task 
> with 3.2.2 release. The cheat worked for demonstration purposes, but it does 
> cause some problems because the {{ObjectMapper}} was constructed locally in 
> the {{BytecodeSerializer}} and therefore could not be updated if the user 
> needed to pass in custom classes to it. Now that there is a pure gryo option, 
> the user can just register gryo serializers to deal with anything that 
> extends on {{Bytecode}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to