[
https://issues.apache.org/jira/browse/TINKERPOP-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523065#comment-15523065
]
ASF GitHub Bot commented on TINKERPOP-1456:
-------------------------------------------
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/434
This is a good batch of new work and updates. I was experimenting with the
`SubgraphStrategy` and wonder if `explain()` should be surfacing the filter
value when a `valueMap()` is used.
```
gremlin> graph = TinkerFactory.createTheCrew()
==>tinkergraph[vertices:6 edges:14]
gremlin> g = graph.traversal()
==>graphtraversalsource[tinkergraph[vertices:6 edges:14], standard]
gremlin> g =
g.withStrategies(SubgraphStrategy.build().vertexProperties(hasLabel('name')).create())
==>graphtraversalsource[tinkergraph[vertices:6 edges:14], standard]
gremlin> g.V().valueMap()
==>[name:[marko]]
==>[name:[stephen]]
==>[name:[matthias]]
==>[name:[daniel]]
==>[name:[gremlin]]
==>[name:[tinkergraph]]
gremlin> g.V().valueMap().explain()
==>Traversal Explanation
=======================================================================================
Original Traversal [GraphStep(vertex,[]),
PropertyMapStep(value)]
SubgraphStrategy [D] [GraphStep(vertex,[]),
PropertyMapStep(value)]
ConnectiveStrategy [D] [GraphStep(vertex,[]),
PropertyMapStep(value)]
RepeatUnrollStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
RangeByIsCountStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
InlineFilterStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
FilterRankingStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
MatchPredicateStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
PathRetractionStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
IncidentToAdjacentStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
AdjacentToIncidentStrategy [O] [GraphStep(vertex,[]),
PropertyMapStep(value)]
TinkerGraphStepStrategy [P] [TinkerGraphStep(vertex,[]),
PropertyMapStep(value)]
ProfileStrategy [F] [TinkerGraphStep(vertex,[]),
PropertyMapStep(value)]
StandardVerificationStrategy [V] [TinkerGraphStep(vertex,[]),
PropertyMapStep(value)]
Final Traversal [TinkerGraphStep(vertex,[]),
PropertyMapStep(value)]
```
> Support SubgraphStrategy.vertexProperties().
> --------------------------------------------
>
> Key: TINKERPOP-1456
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1456
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.4, 3.2.2
> Reporter: Marko A. Rodriguez
>
> We currently support:
> {code}
> SubgraphStrategy.build().vertices()
> SubgraphStrategy.build().edges()
> {code}
> We should also support:
> {code}
> SubgraphStrategy.build().vertexProperties()
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
