[ 
https://issues.apache.org/jira/browse/TINKERPOP-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527071#comment-15527071
 ] 

Marko A. Rodriguez commented on TINKERPOP-844:
----------------------------------------------

Please see {{PropertyMapStep}}. In master/ (3.2.3-SNAPSHOT) a 
{{PropertyMapStep}} can now take a child traversal that gets desired 
properties. The old model of simply using {{vertex.properties(propertyKeys)}} 
still exists. However, as a provider, you can {{setPropertyTraversal()}} to 
{{__.properties(propertyKeys)}} to get the desired effect.

https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/PropertyMapStep.java

If this is sufficient, please close this ticket, else provide feedback.

> PropertyMapStep should reuse PropertiesStep
> -------------------------------------------
>
>                 Key: TINKERPOP-844
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-844
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.0.2-incubating
>            Reporter: Matthias Broecheler
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.2.3
>
>
> Currently, there are two steps which retrieve properties: PropertiesStep and 
> PropertyMapStep. For any vendor implementation wishing to optimize property 
> retrieval this means twice the (redundant) work because each of the steps 
> needs to be extended individually.
> However, the functionality is very similar. PropertyMapStep should be 
> replaced by two steps: PropertiesStep which returns an iterator over 
> properties and a MapAggregatorStep (not tied to the name) which consumes 
> properties from the previous step and builds the map (either with property or 
> values as the the map value) until the element of a property differs.
> This reuse of PropertiesStep would have increase code reuse inside TinkerPop 
> and should not have a significant performance impact. Most importantly, it 
> makes life a lot easier for implementors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to