[
https://issues.apache.org/jira/browse/TINKERPOP-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530640#comment-15530640
]
ASF GitHub Bot commented on TINKERPOP-1467:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/442
TINKERPOP-1467 Corrected a number of problems in close() operations for the
driver [master]
https://issues.apache.org/jira/browse/TINKERPOP-1467
This work was from `tp31` and was pretty heavily conflicted so I decided on
a separate PR. Please see #441 for more information.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1467-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #442
----
commit 934054f83a344ba32db3bcb8617c61340e2087a5
Author: Stephen Mallette <[email protected]>
Date: 2016-09-28T15:06:14Z
Corrected a number of problems in close() operations for the driver.
This was more of a commit than I wanted for tp31, but close() was really
messed up. Fixed a number of race conditions and other logic that would allow
the driver to hang on close. Also made it so that the Cluster makes an attempt
to clean up any Client instances that it spawns.
commit 6c84a71f5b50ba9e8a96b8ec766f26f1c8132b72
Author: Stephen Mallette <[email protected]>
Date: 2016-09-28T18:05:27Z
Merge remote-tracking branch 'origin/TINKERPOP-1467' into
TINKERPOP-1467-master
Conflicts:
CHANGELOG.asciidoc
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
----
> Improve close() operations on the Java driver
> ----------------------------------------------
>
> Key: TINKERPOP-1467
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1467
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
> Affects Versions: 3.1.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Fix For: 3.1.5, 3.2.3
>
>
> A few big problems:
> 1. Client will hang if submitting a request after {{close()}}
> 2. Multiple calls to {{close()}} hangs periodically
> 3. Closing the {{Cluster}} doesn't attempt to clean up open {{Client}}
> instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
