[
https://issues.apache.org/jira/browse/TINKERPOP-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532864#comment-15532864
]
ASF GitHub Bot commented on TINKERPOP-1044:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/440
First of all, thanks for taking the time to do this.
[TINKERPOP-1044](https://issues.apache.org/jira/browse/TINKERPOP-1044) was less
about REST and more about the Gremlin Server protocol but as it turns out the
issue is the same in REST as it is over there.
> there should be some common response between all channelizer methods that
is defined in only one location
There's no such place to do that. There isn't any shared exception
processing logic between REST and the Gremlin Server protocol. I think you
would add that logic here:
https://github.com/apache/tinkerpop/blob/850e159b8dc883ac3995c8d775b8f09b7a64b440/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java#L260-L266
as i look at it now the error messaging logic is a bit weird there to begin
with (i.e. if we don't have an "error message" we just use the class simple
name?? - no idea why that is like that). Note that there are a number of
integration tests that may fail if with these changes you are making as they
rely on the asserting error messages in some cases. If you haven't done so
already please be sure to run those tests:
```text
mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false
```
Also, please add an entry to the CHANGELOG that describes your fix:
https://github.com/apache/tinkerpop/blob/850e159b8dc883ac3995c8d775b8f09b7a64b440/CHANGELOG.asciidoc#tinkerpop-323-release-date-not-officially-released-yet
> ResponseMessage should contain server-side exception name.
> ----------------------------------------------------------
>
> Key: TINKERPOP-1044
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1044
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.1.0-incubating
> Reporter: Bob Briody
> Priority: Minor
>
> When an exception occurs during execution by gremlin server, the
> ResponseMessage currently contains the Exception message, but it would also
> be helpful to include the Exception class name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
