[ 
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551631#comment-15551631
 ] 

ASF GitHub Bot commented on TINKERPOP-1489:
-------------------------------------------

Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/450#discussion_r82163673
  
    --- Diff: gremlin-javascript/pom.xml ---
    @@ -0,0 +1,132 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  ~  Licensed to the Apache Software Foundation (ASF) under one
    +  ~  or more contributor license agreements.  See the NOTICE file
    +  ~  distributed with this work for additional information
    +  ~  regarding copyright ownership.  The ASF licenses this file
    +  ~  to you under the Apache License, Version 2.0 (the
    +  ~  "License"); you may not use this file except in compliance
    +  ~  with the License.  You may obtain a copy of the License at
    +  ~
    +  ~  http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~  Unless required by applicable law or agreed to in writing,
    +  ~  software distributed under the License is distributed on an
    +  ~  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +  ~  KIND, either express or implied.  See the License for the
    +  ~  specific language governing permissions and limitations
    +  ~  under the License.
    +  -->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +    <parent>
    +        <groupId>org.apache.tinkerpop</groupId>
    +        <artifactId>tinkerpop</artifactId>
    +        <version>3.2.3-SNAPSHOT</version>
    +    </parent>
    +    <artifactId>gremlin-javascript</artifactId>
    +    <name>Apache TinkerPop :: Gremlin Javascript</name>
    +    <dependencies>
    +        <dependency>
    +            <groupId>org.apache.tinkerpop</groupId>
    +            <artifactId>gremlin-core</artifactId>
    +            <version>${project.version}</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.codehaus.groovy</groupId>
    +            <artifactId>groovy</artifactId>
    +            <version>${groovy.version}</version>
    +            <classifier>indy</classifier>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.tinkerpop</groupId>
    +            <artifactId>tinkergraph-gremlin</artifactId>
    +            <version>${project.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.tinkerpop</groupId>
    +            <artifactId>gremlin-test</artifactId>
    +            <version>${project.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.tinkerpop</groupId>
    +            <artifactId>gremlin-server</artifactId>
    +            <version>${project.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.slf4j</groupId>
    +            <artifactId>slf4j-log4j12</artifactId>
    +            <version>${slf4j.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +    </dependencies>
    +    <properties>
    +        <!-- provides a way to convert maven.test.skip value to skipTests 
for use in skipping python tests -->
    +        <maven.test.skip>false</maven.test.skip>
    +        <skipTests>${maven.test.skip}</skipTests>
    +        
<gremlin.server.dir>${project.parent.basedir}/gremlin-server</gremlin.server.dir>
    +    </properties>
    +    <build>
    +        <directory>${basedir}/target</directory>
    +        <finalName>${project.artifactId}-${project.version}</finalName>
    +        <plugins>
    +            <plugin>
    +                <groupId>org.codehaus.mojo</groupId>
    +                <artifactId>exec-maven-plugin</artifactId>
    +                <version>1.2.1</version>
    +                <executions>
    +                    <execution>
    +                        <id>generate-javascript</id>
    +                        <phase>generate-test-resources</phase>
    +                        <goals>
    +                            <goal>java</goal>
    +                        </goals>
    +                        <configuration>
    +                            
<mainClass>org.apache.tinkerpop.gremlin.javascript.GenerateGremlinJavascript</mainClass>
    +                            <arguments>
    +                                
<argument>${basedir}/src/main/javascript/gremlin-javascript/process/traversal.js</argument>
    +                                
<argument>${basedir}/src/main/javascript/gremlin-javascript/process/graph-traversal.js</argument>
    +                            </arguments>
    +                        </configuration>
    +                    </execution>
    +                    <execution>
    +                        <id>js-tests</id>
    --- End diff --
    
    It uses JDK `jjs` tool to run the test contained in the 3 test files below 
(see `arguments`).
    Currently it does not produce any output if succeeds, but it fails the 
build if any test fail with the stack trace and error. 


> Provide a Javascript Gremlin Language Variant
> ---------------------------------------------
>
>                 Key: TINKERPOP-1489
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1489
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language-variant
>            Reporter: Jorge Bay
>
> It would be nice to have a Javascript Gremlin Language Variant that could 
> work with any ES5 runtime, specially the ones that support 
> [CommonJs|http://requirejs.org/docs/commonjs.html], like Node.js.
> Nashorn, the engine shipped with JDK 8+, does not implement CommonJs but 
> provides [additional 
> extensions|https://wiki.openjdk.java.net/display/Nashorn/Nashorn+extensions] 
> making modular JavaScript possible. Nashorn should be supported in order to 
> run glv tests under the same infrastructure (JDK8).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to