[
https://issues.apache.org/jira/browse/TINKERPOP-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565692#comment-15565692
]
ASF GitHub Bot commented on TINKERPOP-1495:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/455
TINKERPOP-1495: Global list deduplication doesn't work in OLAP
https://issues.apache.org/jira/browse/TINKERPOP-1495
Two bugs fixed. One is simple -- `RepeatStep` wasn't adding labels to the
"emit traverser" in OLAP. One line update to `RepeatStep.RepeatEndStep`. The
other is related to some `GraphComputing` steps should behave differently if
they are being executed at master or workers. In particular, `DedupGlobalStep`.
Added two new test cases to `DedupTest` provided from the list that
demonstrates the two problems (and shows they are now solved).
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1495
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #455
----
commit 0dcf65921b6045d734d1d6230309f2a1de4f4ee5
Author: Marko A. Rodriguez <[email protected]>
Date: 2016-10-11T14:20:31Z
added GraphComputing.atMaster(boolean) to allow steps (if the want) to know
whether they are executing locally at master or distributed across workers.
This fixes a bug in dedup() on OLAP where non-element traversers were not being
dedup'd correctly.
commit 85eebfab89d9c130f9515e1e8953589a22f8e449
Author: Marko A. Rodriguez <[email protected]>
Date: 2016-10-11T15:06:28Z
Fixed a bug in OLAP RepeatStep where emit().as('x') wasn't behaving
correctly. Basically, forgot to add the step labels to the emitTraverser. One
line fix. Added the complex @dkuppitz traversal DedupTest which demonstrates
that local dedup works correctly in OLAP.
----
> Global list deduplication doesn't work in OLAP
> ----------------------------------------------
>
> Key: TINKERPOP-1495
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1495
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.2
> Reporter: Daniel Kuppitz
> Assignee: Marko A. Rodriguez
>
> {noformat}
> gremlin> g = TinkerFactory.createModern().traversal()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
> gremlin> a = TinkerFactory.createModern().traversal().withComputer()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
> gremlin>
> gremlin>
> g.V().as("a").repeat(both()).times(3).emit().as("b").group().by(select("a")).by(select("b").dedup().order().by(id).fold()).select(values).unfold().dedup()
> ==>[v[1],v[2],v[3],v[4],v[5],v[6]]
> gremlin>
> a.V().as("a").repeat(both()).times(3).emit().as("b").group().by(select("a")).by(select("b").dedup().order().by(id).fold()).select(values).unfold().dedup()
> ==>[v[1],v[2],v[3],v[4],v[5],v[6]]
> ==>[v[1],v[2],v[3],v[4],v[5],v[6]]
> ==>[v[1],v[2],v[3],v[4],v[5],v[6]]
> ==>[v[1],v[3],v[4],v[5],v[6]]
> ==>[v[1],v[2],v[3],v[4],v[6]]
> ==>[v[1],v[2],v[3],v[4],v[5]]
> gremlin>
> {noformat}
> _Not tested in {{tp31}}._
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
