[ 
https://issues.apache.org/jira/browse/TINKERPOP-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610355#comment-15610355
 ] 

Robert Dale commented on TINKERPOP-1468:
----------------------------------------

I guess it depends on how user friendly you want to be Vs. accepting certain 
groovy-isms.

You could null check here and provide a friendly message like the ticket 
suggests.  Ideally that would be consistent everywhere. That could be a lot of 
places.  Is that work done all at once or case by case?

Even with that in place, there are certain groovy-isms that can't be avoided: 
```
gremlin> g.V().choose()
Could not find which method choose() to invoke from this list:
```
But maybe that message is user friendly enough.

I wonder what other GLVs do.

> GraphTraversal.optional throws a NPE if no traversal is provided
> ----------------------------------------------------------------
>
>                 Key: TINKERPOP-1468
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1468
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.2
>            Reporter: Ted Wilmes
>              Labels: trivial
>
> {{GraphTraversal.optional}} throws a NPE if no traversal is provided.  We 
> should probably throw a friendlier exception with instructions to provide a 
> traversal as an argument.
> {code}
> gremlin> g.V().optional()
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.lang.NullPointerException
>       at 
> org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal.optional(GraphTraversal.java:1316)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to