Github user pluradj commented on the issue:

    https://github.com/apache/tinkerpop/pull/457
  
    I verified multiple platforms to ensure the changes didn't have any adverse 
affects.
    
    - On Docker, this builds cleanly with `docker/build.sh -t -n -i`
    
    - On Mac, this builds cleanly with `mvn clean install 
-DskipIntegrationTests=false`
    
    - On Windows, this builds cleanly with `mvn clean install -DskipTests`. 
Following it up with `mvn clean install -DskipIntegrationTests=true` succeeds 
all the way through `hadoop-gremlin`, and then previously witnessed build 
failures on Windows start occurring in `spark-gremlin`. Skipping past 
`spark-gremlin` and `giraph-gremlin`, this builds cleanly to completion with 
`mvn clean install -DskipIntegrationTests=true -DincludeNeo4j -rf 
:neo4j-gremlin`.
    
    Code changes look good to me.
    
    VOTE: +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to