[
https://issues.apache.org/jira/browse/TINKERPOP-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656932#comment-15656932
]
ASF GitHub Bot commented on TINKERPOP-1399:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/487
TINKERPOP-1399 NumberHelper needs to go into util and have a private
constructor
https://issues.apache.org/jira/browse/TINKERPOP-1399
Moved `NumberHelper` into `org.apache.tinkerpop.gremlin.util`. Not that
it's not necessary to add a private constructor, since the only constructor
that exists, is already private.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1399
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #487
----
commit 5c4495eebd7493055502601ebbee990b179951f1
Author: Daniel Kuppitz <[email protected]>
Date: 2016-11-11T12:06:42Z
Moved `NumberHelper` into `org.apache.tinkerpop.gremlin.util`.
----
> NumberHelper needs to go into util and have a private constructor
> -----------------------------------------------------------------
>
> Key: TINKERPOP-1399
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1399
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.1
> Reporter: Marko A. Rodriguez
> Assignee: Daniel Kuppitz
> Labels: breaking
> Fix For: 3.3.0
>
>
> {{NumberHelper}} is in the {{traversal/}} package. That is not good as its
> just a utility class. It should be moved to {{traversal/util}}. Moreover, it
> needs a private constructor so it can't be built as all methods are public
> static.
> This would be a breaking change though I doubt anyone uses this class outside
> of internal TinkerPop.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
