[ 
https://issues.apache.org/jira/browse/TINKERPOP-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15659649#comment-15659649
 ] 

ASF GitHub Bot commented on TINKERPOP-1530:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/489

    TINKERPOP-1530 Consistent use of instance()

    https://issues.apache.org/jira/browse/TINKERPOP-1530
    
    Deprecated `getInstance()` usage in favor of `instance()`. This is a 
non-breaking change for 3.2.0. Will likely remove the deprecated methods for 
3.3.0 as a breaking change
    
    All good with `mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1530

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #489
    
----
commit 185670fa6165d83458326a6b9d80c124966b7402
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-11-12T13:13:22Z

    TINKERPOP-1530 Consistent use of instance()
    
    Deprecated getInstance() usage in favor of instance(). This is a 
non-breaking change for 3.2.0.

----


> Consistent use of instance()
> ----------------------------
>
>                 Key: TINKERPOP-1530
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1530
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver, io, structure
>    Affects Versions: 3.2.3
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>             Fix For: 3.2.4
>
>
> We have indiscriminate use of various versions of {{instance()}} (e.g. 
> {{getInstance()}} - make it all consistent. Implementing this should use 
> deprecation so as not to be breaking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to