Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/499#discussion_r88769492
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java
---
@@ -175,8 +177,30 @@ public PropertyJacksonSerializer() {
public void serialize(final Property property, final JsonGenerator
jsonGenerator, final SerializerProvider serializerProvider)
throws IOException {
jsonGenerator.writeStartObject();
- jsonGenerator.writeObjectField(GraphSONTokens.KEY,
property.key());
+ jsonGenerator.writeStringField(GraphSONTokens.KEY,
property.key());
jsonGenerator.writeObjectField(GraphSONTokens.VALUE,
property.value());
+ if (property.element() instanceof VertexProperty) {
+ VertexProperty vertexProperty = (VertexProperty)
property.element();
+
jsonGenerator.writeObjectFieldStart(GraphSONTokens.ELEMENT);
+ jsonGenerator.writeStringField(GraphSONTokens.VALUETYPE,
"g:VertexProperty");
+
jsonGenerator.writeObjectFieldStart(GraphSONTokens.VALUEPROP);
+ jsonGenerator.writeObjectField(GraphSONTokens.ID,
vertexProperty.id());
+ jsonGenerator.writeStringField(GraphSONTokens.LABEL,
vertexProperty.label());
+ jsonGenerator.writeObjectField(GraphSONTokens.VERTEX,
vertexProperty.element().id());
+ jsonGenerator.writeEndObject();
+ jsonGenerator.writeEndObject();
+ } else if (property.element() instanceof Edge) {
+ Edge edge = (Edge) property.element();
+
jsonGenerator.writeObjectFieldStart(GraphSONTokens.ELEMENT);
+ jsonGenerator.writeStringField(GraphSONTokens.VALUETYPE,
"g:Edge");
--- End diff --
This will write an object of type "g:Edge" but will not contain the same
content than what a Edge serializer would have serialized, and so the contents
are inconsistent. Here what is missing is the out/inVLabel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
