[
https://issues.apache.org/jira/browse/TINKERPOP-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710150#comment-15710150
]
ASF GitHub Bot commented on TINKERPOP-1573:
-------------------------------------------
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/507
Okay, I see what you're saying. I fixed that and here's another version:
https://gist.github.com/dkuppitz/47bae08ab19c848f663d95c7213da26b
What I'm worried about in your implementation is the `MAP.get()` in every
method. Look into the `ThreadLocal` implementation how nasty this call can get.
> Bindings don't work in coalesce
> -------------------------------
>
> Key: TINKERPOP-1573
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1573
> Project: TinkerPop
> Issue Type: Bug
> Components: structure
> Affects Versions: 3.2.3
> Reporter: Robert Dale
> Assignee: Marko A. Rodriguez
>
> {noformat}
> gremlin> graph = EmptyGraph.instance()
> ==>emptygraph[empty]
> gremlin> g = graph.traversal().withRemote('conf/remote-graph.properties')
> ==>graphtraversalsource[emptygraph[empty], standard]
> gremlin> g.addV('fof').property('key',234)
> ==>v[0]
> gremlin> b = new Bindings()
> ==>{}
> gremlin>
> g.withBindings(b).V().has('fof','key',234).coalesce(__.V().has(b.of('l','fof'),
> b.of('k', 'key'), b.of('v',234)),
> __.addV(b.of('nl','fof')).property(b.of('sk','key'),
> b.of('sv',234))).property(b.of('nk','newkey'),
> b.of('nv','newvalue')).asAdmin().getBytecode()
> ==>[[], [V(), has(fof, key, 234), coalesce([[], [V(), has(fof, key, 234)]],
> [[], [addV(fof), property(key, 234)]]), property(binding[nk=newkey],
> binding[nv=newvalue])]]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
