[ 
https://issues.apache.org/jira/browse/TINKERPOP-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712325#comment-15712325
 ] 

ASF GitHub Bot commented on TINKERPOP-1562:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/510
  
    @okram one thing that could use your explict review here - we lost the 
ability to do wildcard imports given the work you did on `CoreImports` for 
gremlin-python. Some plugins used a lot of wildcards, specifically the hadoop 
plugin:
    
    
https://github.com/apache/tinkerpop/blob/90f427c8dc11636a5884e6cca3c0a22249d26576/hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/jsr223/HadoopGremlinPlugin.java
    
    I didn't go through hadoop APIs to add all the classes that were 
wildcarded. can you please give a review to see if anything else should be 
added there?



> Migrate ScriptEngine-related code to gremlin-core
> -------------------------------------------------
>
>                 Key: TINKERPOP-1562
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1562
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: groovy
>    Affects Versions: 3.2.3
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>              Labels: breaking
>
> Migrate classes and features of {{ScriptEngine}} to gremlin-core and 
> {{GremlinScriptEngine}}. There is a minor breaking change where the 
> {{ImportCustomizer}} class needs to become an interface. As the class itself 
> played no real role in operations of 3.2.3 it's doubtful that this should be 
> a big breaking change for users as no one was likely using it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to