[ 
https://issues.apache.org/jira/browse/TINKERPOP-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715084#comment-15715084
 ] 

ASF GitHub Bot commented on TINKERPOP-1363:
-------------------------------------------

Github user dkuppitz commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/508#discussion_r90638755
  
    --- Diff: CHANGELOG.asciidoc ---
    @@ -26,6 +26,7 @@ 
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
     TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     
    +* Updated Docker build scripts to include Python dependencies (NOTE: users 
should remove any previously generated TinkerPop Docker images).
    --- End diff --
    
    Okay, reminder to dev list sounds good to me (although I think that all the 
people who actually use the Docker script, participated in the review of this 
PR). Final word on the note in the upgrade docs? I tend to say we don't need a 
note there.


> Cleanup Docker build script for next major release
> --------------------------------------------------
>
>                 Key: TINKERPOP-1363
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1363
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: build-release
>    Affects Versions: 3.2.1
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>              Labels: breaking
>             Fix For: 3.3.0
>
>
> https://github.com/apache/tinkerpop/commit/2b9901d704c9c5cb1ad618b3cf67f9ec646cf5e5
> ^^ This commit contains a quick fix. The installation of setuptools should 
> happen in the Docker base image setup; however, this can only be done for the 
> next major release as it's a breaking change for the Docker build script 
> (developers will have to remove / rebuild their local base images).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to