[
https://issues.apache.org/jira/browse/TINKERPOP-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795361#comment-15795361
]
ASF GitHub Bot commented on TINKERPOP-1130:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/520
TINKERPOP-1130 IO Testing
https://issues.apache.org/jira/browse/TINKERPOP-1130
Added `gremlin-io-test` module under the `gremlin-tools` module. It
provides more complete testing of IO related capabilities of GraphSON and Gryo.
The testing helps with maintaining compliance of different versions of GraphSON
and Gryo. Stubbed in Gryo 3.0.
This change also allows for slightly more automated generation of the
`dev/io` docs for GraphSON. If you do: `mvn clean install -Dio` it will
generate the asciidoc for the GraphSON sections to `target/dev-docs`. From the
content of those files can be cut/paste to the asciidoc files in `dev/io`. That
directory also holds a `model.csv` file which has data about the various
version compatibilities. Having it in that format makes it pretty easy to see
formats are compatible with what versions of specific releases.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1130
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #520
----
commit df67d7a413e3525db7c69167c729c0522bbb8445
Author: Stephen Mallette <[email protected]>
Date: 2016-12-14T16:50:38Z
TINKERPOP-1130 Structured the IO compatibility tests
commit fc7b4457d8e740dc17bedafdd569db52e016b619
Author: Stephen Mallette <[email protected]>
Date: 2016-12-14T22:41:30Z
TINKERPOP-1130 Implemented many additional IO tests.
Cleaned up inconsistencies in how static files are stored. Improved asserts.
commit 8a2241c2cb290a9ac6b4976967ef16bfff485fe6
Author: Stephen Mallette <[email protected]>
Date: 2016-12-15T16:55:16Z
TINKERPOP-1130 Completed tests for typed IO
Still need some asserts and found lots of inconsistencies that were handled
in the Model class with Compatibility assignments.
commit a10910f7dcd97cac274534e24cf0c4973376795f
Author: Stephen Mallette <[email protected]>
Date: 2016-12-15T18:58:20Z
TINKERPOP-1130 Made the test data for metrics static.
This helps prevent the data from regenerating on every build.
commit 4549ed025fe7d1dac9ed486a085a3aaf936cbd07
Author: Stephen Mallette <[email protected]>
Date: 2016-12-15T19:40:00Z
TINKERPOP-1130 Improved asserts on Graph elements.
commit fb0bb0182f9fd9becf64b06c90a08988e6fc0f2e
Author: Stephen Mallette <[email protected]>
Date: 2016-12-16T11:56:55Z
TINKERPOP-1130 Changed scope of gremlin-test to "test"
commit ab206a728e441cfe643a30973172115e179a97d4
Author: Stephen Mallette <[email protected]>
Date: 2016-12-19T14:16:11Z
TINKERPOP-1130 Add gremlin-test back as compile scope.
It can't be test scope since non-test code uses commons-io which comes from
gremlin-test. Shouldn't be any harm in including gremlin-test this way as this
is a utility module that isn't deployed or anything.
commit 50d179d31ad03adc3d16b37f6261777898b82c22
Author: Stephen Mallette <[email protected]>
Date: 2016-12-21T20:35:23Z
TINKERPOP-1130 Get the basics of Gryo 3.0 in place.
commit 7503d33a6fb4df9e8e1471162a87456195ef6fe9
Author: Stephen Mallette <[email protected]>
Date: 2016-12-21T20:52:30Z
TINKERPOP-1130 Enabled testing of int/double for GraphSON
Thanks to fixes in tp32/master it's now possible to test these primitive
data types.
commit 12b472d6c1153f20ccb8689fd8ff88feabfb1dee
Author: Stephen Mallette <[email protected]>
Date: 2016-12-22T18:39:10Z
TINKERPOP-1130 Enabled GraphSON serialization tests for enums
Fixes on tp32 related to enum serialization allowed these tests to start
working.
commit cc5904d5d88049df541280b794bf7d8e694539b8
Author: Stephen Mallette <[email protected]>
Date: 2016-12-23T13:34:40Z
TINKERPOP-1130 Added test support for ConjunctiveP in Gryo
This is now possible given fixes on tp32/master.
commit ebebc9af65af4400b00b0483ffd3a97d02defcaa
Author: Stephen Mallette <[email protected]>
Date: 2016-12-27T12:47:09Z
TINKERPOP-1130 Add 3.2.4 data files for gremlin-io-test
commit 7be09ae9a64ec8890cfae4761409394069f50d15
Author: Stephen Mallette <[email protected]>
Date: 2016-12-27T15:44:59Z
TINKERPOP-1130 Fixed ByteBuffer compatibility with Gryo.
Required a fix to 3.2.4 and the tp32 branch for this to work completely.
commit 6088ead30b31d5c13de35fa95261d4bc4a11a8f1
Author: Stephen Mallette <[email protected]>
Date: 2016-12-27T17:19:03Z
TINKERPOP-1130 Enable more tests on gryo 1.0 and 3.3.0.
commit ad72c472e0bbdec299a8dda7b47b568ba9fc2b64
Author: Stephen Mallette <[email protected]>
Date: 2016-12-27T18:49:53Z
TINKERPOP-1130 Added "incompatibility notes"
Provides a way to explain why something is untested (which essentially
means incompatible) in the Model.
commit baf1d1700fa57b652ff938c5cd737b11a28f0b96
Author: Stephen Mallette <[email protected]>
Date: 2016-12-29T11:58:03Z
TINKERPOP-1130 Added TinkerGraph support in gremlin-io-test
Fixes in tp32/master allowed this to suddenly be supported.
commit ef12395486c2753cb452afac563a688a316c5595
Author: Stephen Mallette <[email protected]>
Date: 2016-12-29T12:40:25Z
TINKERPOP-1130 Added more asserts for Element related tests
commit 7f94d2952532b6d7dd8e00499d47cb949f4b1a5f
Author: Stephen Mallette <[email protected]>
Date: 2016-12-29T14:34:39Z
TINKERPOP-1130 Revised the model for Tree
Added more asserts for the Tree.
commit 86e04c689e29934273e57e81dd9478a5c96f8d5a
Author: Stephen Mallette <[email protected]>
Date: 2016-12-29T15:27:01Z
TINKERPOP-1130 Added Request/ResponseMessage incompatibilty reasons.
commit c5c9517f2eef67b41d51b699ae68966d0be6ffc4
Author: Stephen Mallette <[email protected]>
Date: 2016-12-29T18:20:53Z
TINKERPOP-1130 Add Compatiblities helper class
Makes it easier to express ranges of versions for defining compatiblity in
the Model.
commit 08147db4792a9852423f25c56155a5bc5ec743fa
Author: Stephen Mallette <[email protected]>
Date: 2016-12-29T19:05:20Z
TINKERPOP-1130 Added configuration filter for Compatibilities
commit f6654add7263cd8aeb4744382bf1c80e59ea3ff7
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T13:08:51Z
TINKERPOP-1130 Move common compatibility filters to Compatibilities
commit e656be6c2faa94e162e5643e2302d51931eb5674
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T13:37:49Z
TINKERPOP-1130 Removed support for testing "time" with untyped GraphSON
commit 781aeba2e7a77acdea78a4b594f137c67c4d0e95
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T13:40:24Z
TINKERPOP-1130 Added back graphson generation script for 3.2.4
Was deleted by accident on previous commit.
commit 20727db4433ee371b3b7a57ae67b6d4f011bf45a
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T15:26:02Z
TINKERPOP-1130 Tests for edge untyped graphson
commit fff3e98ad7d5b89cde3e4f43197bad4e1f1de487
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T15:35:28Z
TINKERPOP-1130 Testing for Path untyped GraphSON
commit d14e66c479b443d16d0b29461d54c944f807f3f4
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T16:26:13Z
TINKERPOP-1130 Finished tests for untyped structure elements.
commit c09904848485ae99e92d4795b5091ea85960249a
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T17:58:56Z
TINKERPOP-1130 Completed GraphSON tests for Request/ResponseMessage
commit 320c019b10794effca21bc55d9a925d8a15715bc
Author: Stephen Mallette <[email protected]>
Date: 2016-12-30T19:46:34Z
TINKERPOP-1130 Regenerated IO docs for GraphSON
commit e6f7c90a8bdaf55ec6288fe14e05f22cf3438ab0
Author: Stephen Mallette <[email protected]>
Date: 2016-12-31T11:05:20Z
TINKERPOP-1130 Cleaned up compatibility definitions
Identified todos requires to get this body of work complete. Explicitly
marked "no-type" graphson incompabilities.
----
> Each release should store Kryo/GraphSON/GraphML versions to ensure future
> compatibility
> ---------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1130
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1130
> Project: TinkerPop
> Issue Type: Improvement
> Components: io, test-suite
> Affects Versions: 3.1.1-incubating
> Reporter: Marko A. Rodriguez
> Labels: breaking
>
> I think we should make a new toy data set that has all the graph structure
> features in it -- vertices, edges, vertex properties, multi-properties,
> meta-properties, graph variables, different edge labels with different
> property keys, etc. etc.
> The graph doesn't have to be big, it just needs to cover all the features.
> Next, we should then stamp out a version of that file at every release:
> {code}
> graph-test-x.y.z.xml
> graph-test-x.y.z.kryo
> graph-test-x.y.z.json
> graph-test-x.y.z-typed.json
> {code}
> Then we should have a test case that verifies that the current SNAPSHOT
> {{GryoReader}}, {{GraphSONReader}}, {{GraphMLReader}}, etc. can still read
> those files. If they can't, then we have introduced a change in our
> serialization format.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
