Github user okram commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/524#discussion_r95001231
  
    --- Diff: 
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/SparkInterceptorStrategyTest.java
 ---
    @@ -142,7 +142,7 @@ public void 
shouldSuccessfullyEvaluateInterceptedTraversals() throws Exception {
             test(6l, g.V().out().values("name").count());
             test(2l, g.V().out("knows").values("name").count());
             test(3l, g.V().in().has("name", "marko").count());
    -        test(6l, g.V().repeat(__.dedup()).times(2).count());
    +        test(0l, g.V().repeat(__.dedup()).times(2).count());
    --- End diff --
    
    This is crazy. The right answer is `0`. Think about it. It goes through 
once, fine, all 6 vertices. The second time -- already seem them! Filter. Thus, 
0.
    
    However, I just checked OLTP and it assumes 6. Wondering what is "right" ?. 
.... 
    
    ```
    gremlin> g = TinkerFactory.createModern().traversal()
    ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
    gremlin> g.V().repeat(dedup()).times(2)
    ==>v[1]
    ==>v[2]
    ==>v[3]
    ==>v[4]
    ==>v[5]
    ==>v[6]
    gremlin> g.withComputer().V().repeat(dedup()).times(2)
    gremlin>
    ```
    
    Whatever, is decided as the correct answer, we should definitely put this 
into `RepeatTest`. I just randomly had this query in a Spark test.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to