[
https://issues.apache.org/jira/browse/TINKERPOP-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815728#comment-15815728
]
ASF GitHub Bot commented on TINKERPOP-1531:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/530
TINKERPOP-1531:
DedupTest.g_V_asXaX_repeatXbothX_timesX3X_emit_asXbX_group_byXselectXaXX_byXselectXbX_dedup_order_byXidX_foldX_selectXvaluesX_unfold_dedup
assumes id implements Comparable
https://issues.apache.org/jira/browse/TINKERPOP-1531
We were ordering on `T.id` and not all providers have `Comparable` ids. The
test has been updated (and renamed) to use vertex names.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1531
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/530.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #530
----
commit 683c2dfa80ddb2fe5f9c19e6a3f9d6f9e9db4950
Author: Marko A. Rodriguez <[email protected]>
Date: 2017-01-10T18:19:37Z
DedupTest now uses name for the order() instead of id.
----
> DedupTest.g_V_asXaX_repeatXbothX_timesX3X_emit_asXbX_group_byXselectXaXX_byXselectXbX_dedup_order_byXidX_foldX_selectXvaluesX_unfold_dedup
> assumes id implements Comparable
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1531
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1531
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.2.3
> Reporter: pieter martin
> Priority: Minor
>
> {noformat}DedupTest.g_V_asXaX_repeatXbothX_timesX3X_emit_asXbX_group_byXselectXaXX_byXselectXbX_dedup_order_byXidX_foldX_selectXvaluesX_unfold_dedup{noformat}
> includes {noformat}order().by(T.id){noformat} which assumes that the id
> implements Comparable.
> As ids are specified as Object this is not always true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
