[
https://issues.apache.org/jira/browse/TINKERPOP-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830114#comment-15830114
]
ASF GitHub Bot commented on TINKERPOP-1606:
-------------------------------------------
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/539
Just realized that the `GroupStep` work fixed:
https://issues.apache.org/jira/browse/TINKERPOP-1261
```
gremlin> m = ["marko":['blah']]
==>marko=[blah]
gremlin> g.withSideEffect("m",
m).V().hasLabel("person").group("m").by("name").by(out("created").values("name").fold()).cap("m")
==>[marko:[blah,lop],vadas:[],josh:[ripple,lop],peter:[lop]]
```
Will add a definitive test case to `GroupTest`.
> Refactor GroupStep to not have the reduction traversal included in its
> BiOperator.
> ----------------------------------------------------------------------------------
>
> Key: TINKERPOP-1606
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1606
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.3
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> {{GroupStep}} has a complicated {{BiOperator}} (its reducer). I believe we
> can simplify it significantly by considering only two states.
> 1. A {{by()}}-modulation that does NOT have a {{Barrier}}.
> 2. A {{by()}}-modulation that DOES have a {{Barrier}}.
> For the first, simply store a single {{Traverser}}. No need to aggregate all
> traversers as only one will ultimately be emitted.
> For the latter, simply store the barrier's BiOperator (NOT the step itself).
> In this way, we will no longer have to encode a traversal in the reducer and
> thus, will remove various potential problems associated with detached
> traversals.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
