GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/558

    TINKERPOP-1631 Improvements to BindingsGremlinPlugin

    https://issues.apache.org/jira/browse/TINKERPOP-1631
    
    This PR is a bit in the weeds. You can read the JIRA issue if you want a 
few more details, but basically most of this is driven by the work being done 
in master to get rid of gremlin-groovy-test.
    
    Builds fine with docker.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1631

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
    
----
commit 66ab01bad354d5933ce169c8fb7e679ad8050fa6
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-02-13T13:50:45Z

    TINKERPOP-1631 Got rid of old deprecated syntax for creating TraversalSource

commit 4818565467e6b847007dbb4032484a3efb6d091e
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-02-13T13:51:51Z

    TINKERPOP-1631 Improved consistency of binding application to 
GremlinScriptEngine
    
    Added a base factory class. Added start of a test framework for 
GremlinScriptEngineFactory. Pushed all bindings to global - engine is overriden 
at time of eval() by "parameters".

commit c6bbbd61516eee428a9c5a7bce2fd474a2359e87
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-02-13T14:14:48Z

    TINKERPOP-1631 Show message when global scope bindings conflict

commit d694dfa3c651d97797bd3a694bf15dfeab06e1f5
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-02-14T12:28:48Z

    TINKERPOP-1634 Deprecated CustomizerProvider infrastructure

commit 28a0ad3e43a969ed529a5a1777bc47ffde9ab0f9
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-02-14T12:31:49Z

    TINKERPOP-1631 Updated changelog

commit b57de665ab6ade256b2755ba9d94c40fadb37f1c
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-02-14T20:44:52Z

    TINKERPOP-1631 Limit bindings test to gremlin-groovy.
    
    This test uses a script that is groovy based. Would need to generalize the 
test to be better suited for all GremlinScriptEngine implementations.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to