[ 
https://issues.apache.org/jira/browse/TINKERPOP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869750#comment-15869750
 ] 

ASF GitHub Bot commented on TINKERPOP-1443:
-------------------------------------------

Github user metlos commented on the issue:

    https://github.com/apache/tinkerpop/pull/494
  
    So in another words it is a matter of setting up the level of breakage you 
want to allow between different Tinkerpop versions. I based the "minor increase 
allows breaking changes" on the "feeling" I got from how Tinkerpop changed over 
time, but you may want to modify it if you so choose.


> Use an API checker during build
> -------------------------------
>
>                 Key: TINKERPOP-1443
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1443
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: build-release
>    Affects Versions: 3.2.2
>            Reporter: Lukas Krejci
>            Assignee: stephen mallette
>
> Tinkerpop 3.2.2 changed the signature of the method 
> {{GraphTraversal.hasLabel}} from {{(String...)}} to {{(String, String...)}}. 
> While this is certainly an improvement, it is both source and binary 
> incompatible change.
> I.e. even if every usage of {{hasLabel}} had at least one parameter in the 
> user code, none of those calls will work until all the user code is 
> recompiled using Tinkerpop 3.2.2.
> I don't know the versioning policy of Tinkerpop but changes like the above in 
> a micro/patch release are generally unexpected.
> Please consider API checkers like http://revapi.org to warn about such 
> incompatible API changes...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to