[
https://issues.apache.org/jira/browse/TINKERPOP-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886370#comment-15886370
]
ASF GitHub Bot commented on TINKERPOP-1554:
-------------------------------------------
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/560
Realizing that this should really go into `master/` as I just walked
through a bunch of the code and notes that we use `PropertiesStep` a lot
through out various traversal strategies. Going to change my VOTE to -1 as this
problem is more complicated that I originally assumed.
> has(propertyKey) should have a corresponding step in Gremlin-Java.
> ------------------------------------------------------------------
>
> Key: TINKERPOP-1554
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1554
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.3
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> Currently {{has('name')}} compiles to {{filter(values('name'))}}. This is bad
> for a few reasons:
> 1. Its slower than a direct step.
> 2. Its nested traversals which increases reasoning time of strategies.
> 3. Its not clear from bytecode what it going on.
> I propose:
> {code}
> public class HasPropertyStep<S extends Element> implements FilterStep<S> {
> private String propertyKey;
> public boolean filter(final Traverser.Admin<S> traverser) {
> return traverser.get().properties(propertyKey).hasNext();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
