GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/565
TINKERPP-1612 Remove gremlin-groovy-test
https://issues.apache.org/jira/browse/TINKERPOP-1612
This pull request removes the `gremlin-groovy-test` module. Recall that
these tests were deprecated in 3.2.4 and are good for removal at this point
given changes to the testing approaches to GLVs. Removing it required a fairly
heavy refactoring of `GremlinScriptEngine`, Gremlin Console, and Gremlin Server
given that testing of a lot of the `GremlinScriptEngine` stuff was being
accomplished through that module. As much of that infrastructure was moved down
to `gremlin-core` it force a change of a lot of things. In short this PR
touched a lot of stuff and there was really no way to do this in any smaller
effort.
The old `GremlinPlugin` system of `gremlin-groovy` has been completely
replaced by the more generalized system put in place in 3.2.4 (the old system
was deprecated at that point). There is no more dual mode to the operations of
the console.
Note that this PR also covers:
https://issues.apache.org/jira/browse/TINKERPOP-1421
https://issues.apache.org/jira/browse/TINKERPOP-1621
https://issues.apache.org/jira/browse/TINKERPOP-1622
which are related to removal of deprecated code in some way related to
`GremlinScriptEngine` or "plugin" infrastructure.
There were a number of changes to documentation and the doc generation
system in support of these changes. Docs generate without issue at this point
using the new plugin system.
The build is good with `docker/build.sh -t -i -n` - VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1612
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #565
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
