[ 
https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890093#comment-15890093
 ] 

ASF GitHub Bot commented on TINKERPOP-1640:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/566
  
    Took a body of failure with the docker build:
    
    ```text
    Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.663 sec 
<<< FAILURE! - in 
org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest
    
shouldHandleSideEffectsCorrectly(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest)
  Time elapsed: 0.347 sec  <<< ERROR!
    
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException:
 VertexComputing steps must be executed with a GraphComputer: 
[TraversalVertexProgramStep([GraphStep(vertex,[]), 
CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])]
        at 
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.<init>(TraversalExplanation.java:58)
        at 
org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225)
        at 
org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest.shouldHandleSideEffectsCorrectly(SparkInterceptorStrategyTest.java:73)
    
    
shouldSuccessfullyEvaluateInterceptedTraversals(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest)
  Time elapsed: 0.315 sec  <<< ERROR!
    
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException:
 VertexComputing steps must be executed with a GraphComputer: 
[TraversalVertexProgramStep([GraphStep(vertex,[]), 
CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])]
        at 
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.<init>(TraversalExplanation.java:58)
        at 
org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225)
        at 
org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkInterceptorStrategyTest.shouldSuccessfullyEvaluateInterceptedTraversals(SparkInterceptorStrategyTest.java:101)
    
    Running 
org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest
    Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.339 sec 
<<< FAILURE! - in 
org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest
    
shouldSuccessfullyEvaluateSingleIterationTraversals(org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest)
  Time elapsed: 0.339 sec  <<< ERROR!
    
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.VerificationException:
 VertexComputing steps must be executed with a GraphComputer: 
[TraversalVertexProgramStep([GraphStep(vertex,[]), 
CountGlobalStep],graphfilter[[VertexStep(BOTH,edge), RangeGlobalStep(0,0)]])]
        at 
org.apache.tinkerpop.gremlin.process.traversal.strategy.verification.StandardVerificationStrategy.apply(StandardVerificationStrategy.java:52)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:114)
        at 
org.apache.tinkerpop.gremlin.process.traversal.util.TraversalExplanation.<init>(TraversalExplanation.java:58)
        at 
org.apache.tinkerpop.gremlin.process.traversal.Traversal.explain(Traversal.java:225)
        at 
org.apache.tinkerpop.gremlin.spark.process.computer.traversal.strategy.optimization.SparkSingleIterationStrategyTest.shouldSuccessfullyEvaluateSingleIterationTraversals(SparkSingleIterationStrategyTest.java:72)
    
    Running 
org.apache.tinkerpop.gremlin.spark.process.computer.CombineIteratorTest
    Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.633 sec - 
in org.apache.tinkerpop.gremlin.spark.process.computer.CombineIteratorTest
    Running 
org.apache.tinkerpop.gremlin.spark.process.computer.LocalPropertyTest
    [WARN] 
org.apache.tinkerpop.gremlin.hadoop.process.computer.AbstractHadoopGraphComputer$Features
 - No gremlin.hadoop.graphWriter property provided and thus, persistence 
options are unknown -- assuming all options are possible
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.081 sec - 
in org.apache.tinkerpop.gremlin.spark.process.computer.LocalPropertyTest
    
    Results :
    
    Tests in error: 
      SparkInterceptorStrategyTest.shouldHandleSideEffectsCorrectly:73 ? 
Verification
      
SparkInterceptorStrategyTest.shouldSuccessfullyEvaluateInterceptedTraversals:101
 ? Verification
      
SparkSingleIterationStrategyTest.shouldSuccessfullyEvaluateSingleIterationTraversals:72
 ? Verification
    ```
    
    btw, it would be helpful to have some javadoc on the strategy you 
added/modified - they have pretty simple functionality but an explanation of 
what they do and why they are required makes everything easier to follow at a 
glance.


> ComputerVerificationStrategy gives false errors
> -----------------------------------------------
>
>                 Key: TINKERPOP-1640
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1640
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.4
>            Reporter: Daniel Kuppitz
>            Assignee: Marko A. Rodriguez
>
> I've added a new complex test that fails in OLAP. Unfortunately the test 
> runner only marks the test as "ignored" as that's what we usually we want 
> when a {{VerificationException}} is thrown. However, in this case the 
> exception ("It is not possible to access more than a path element's id on 
> GraphComputer: ...") is wrong.
> Another issue that I just noticed is, that the same test throw serialization 
> exceptions in the {{\*Translator\*}} test suites.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to