[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922814#comment-15922814
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
-------------------------------------------

Github user robertdale commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/570#discussion_r105747173
  
    --- Diff: docs/src/reference/gremlin-applications.asciidoc ---
    @@ -1560,6 +1560,11 @@ and standard deviation evaluation times, as well as 
the 75th, 95th, 98th, 99th a
     * `op.traversal` - the number of `Traveral` executions, mean rate, 1, 5, 
and 15 minute rates, minimum, maximum, median,
     mean, and standard deviation evaluation times, as well as the 75th, 95th, 
98th, 99th and 99.9th percentile evaluation
     times.
    +* `engine-name.session.session-id.*` - metrics related to different 
`GremlinScriptEngine` instanc configured for
    +session-based requests where "engine-name" will be the actual name of the 
engine, such as "gremlin-groovy" and
    +"session-id" will be the identifier for the session itself.
    +* `engine-name.sessionless.*` - metrics related to different 
`GremlinScriptEngine` instanc configured for sessionless
    --- End diff --
    
    instances


> Improve script compilation process and include metrics
> ------------------------------------------------------
>
>                 Key: TINKERPOP-1644
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: groovy
>    Affects Versions: 3.2.4
>            Reporter: Bryn Cooke
>            Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to