[
https://issues.apache.org/jira/browse/TINKERPOP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928385#comment-15928385
]
ASF GitHub Bot commented on TINKERPOP-1387:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/574#discussion_r106466930
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/CyclicPathStep.java
---
@@ -1,46 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.tinkerpop.gremlin.process.traversal.step.filter;
-
-import org.apache.tinkerpop.gremlin.process.traversal.Traversal;
-import org.apache.tinkerpop.gremlin.process.traversal.Traverser;
-import
org.apache.tinkerpop.gremlin.process.traversal.traverser.TraverserRequirement;
-
-import java.util.Collections;
-import java.util.Set;
-
-/**
- * @author Marko A. Rodriguez (http://markorodriguez.com)
- */
-public final class CyclicPathStep<S> extends FilterStep<S> {
--- End diff --
As this is going to `tp32`, wouldn't it be better to mark this as
deprecated in favor of `PathFilterStep`? It's final, so no one could have
extended from it, but perhaps they used it in some other way? I guess I'd be in
favor of doing the same for `SimplePathStep`.
> from and to modulators for path steps
> -------------------------------------
>
> Key: TINKERPOP-1387
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1387
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.1
> Reporter: Daniel Kuppitz
> Assignee: Marko A. Rodriguez
>
> Just had this crazy idea of {{from}} and {{to}} modulators for path steps.
> {code}
> g.V(1).as("a").
>
> repeat(both("knows").simplePath().from("a")).emit().out("created").as("p").in("created").
>
> repeat(both("knows").simplePath().from("p")).emit(hasId(6)).out("created").as("b").
> path().from("a").to("p").as("pathFromMarkoToProject").
> path().from("p").to("b").as("pathFromProjectToPeter").
> match(
> __.as("pathFromMarkoToProject").count(local).is(lte(3)),
> __.as("pathFromProjectToPeter").count(local).is(lte(3))
> ).select("p", "pathFromMarkoToProject", "pathFromProjectToPeter")
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
