Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/583
  
    > I think this abstraction could be applied fairly easily to the 
`WebSocketsChannelizer`
    
    You're right.
    
    > Well, it's not the root of the configuration file. It's under 
`authentication : { ... }`.
    
    sorry - i missed that and all the better that it can be generally applied 
to the `WebSocketChannelizer` as i agreed above. of course, given both of the 
above points, something doesn't feel right. Let me try to explain. It seems 
like we have a pluggable authentication schema already in SASL and now this 
pull request suggest that we make SASL pluggable. I think we just need to make 
the `HttpChannelizer` use SASL. Then if someone wants to do HMAC (or whatever 
custom security theme) they implement through SASL.  Does that make sense?
    
    > I think this PR is a small, iterative change that doesn't break anything.
    
    agreed - this PR is well scoped as it is. i didn't mean to suggest 
expanding it, especially now that i understand that the change isn't at the 
root of the yaml.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to