Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/569
I've finished playing around with my dummy implementation. Just one weird
thing that wasn't easy to see without actually working with the API -
`addTraversalSource()` and `addGraph()` aren't really "adds" - they are "puts"
as calling them more than once will act as a "replace" operation if the key
already exists. I think we want the behavior to generally be a "replace" and
thus "putTraversalSource()" and "putGraph()" seem like better names. I suppose
if an implementation wanted to limit that ability to only "adds" then the
naming with "put" still makes sense as we can see with the use of `Map.put()`
in unmodifiable collections.
I see some other odds/ends that could use a tweak or two, but I'll just
handle those things after merging as I think you have the meat of this PR in
place now once you address those other comments I've made. Please confirm that
you've done a final build with integration tests after all these changes to
make sure it's all solid. At that point, I expect we can get committers to
review/vote.
This has developed into a really nice pull request. Your effort on it is
appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
