[
https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949211#comment-15949211
]
ASF GitHub Bot commented on TINKERPOP-1438:
-------------------------------------------
Github user dpitera commented on the issue:
https://github.com/apache/tinkerpop/pull/569
> I think we want the behavior to generally be a "replace" and thus
"putTraversalSource()" and "putGraph()" seem like better names.
+1
> This has developed into a really nice pull request. Your effort on it is
appreciated.
Thank you sir. Your outstanding review is also very much appreciated.
I just pushed new code with all requested changes; once the TravisCI and
Docker IT tests pass, I will post again for hopefully the final review.
> Consider GraphManager as an interface
> -------------------------------------
>
> Key: TINKERPOP-1438
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1438
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.2.2
> Reporter: stephen mallette
> Priority: Minor
> Labels: breaking
>
> If {{GraphManager}} were an interface it would make embedding Gremlin Server
> easier as {{Graph}} instances could be more easily supplied by the host
> application. In doing this, It also might be good to force a
> {{TraversalSource}} to be referred to by both the {{Graph}} name and
> {{TraversalSource}} name.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
