[
https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958963#comment-15958963
]
ASF GitHub Bot commented on TINKERPOP-1664:
-------------------------------------------
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/590#discussion_r110167099
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/ElementHelper.java
---
@@ -116,6 +116,10 @@ public static void legalPropertyKeyValueArray(final
Object... propertyKeyValues)
for (int i = 0; i < propertyKeyValues.length; i = i + 2) {
if (!(propertyKeyValues[i] instanceof String) &&
!(propertyKeyValues[i] instanceof T))
throw
Element.Exceptions.providedKeyValuesMustHaveALegalKeyOnEvenIndices();
+
+ if (propertyKeyValues[i + 1] == null) {
--- End diff --
```
if(null == propertyKeyValues[i+1])
throw Property.Exceptions.propertyValueCanNotBeNull();
```
> StarVertexProperty#property should throw an NPE if the value is null
> --------------------------------------------------------------------
>
> Key: TINKERPOP-1664
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1664
> Project: TinkerPop
> Issue Type: Improvement
> Components: structure
> Affects Versions: 3.2.4
> Reporter: Bryn Cooke
>
> Currently properties are checked for nullness but meta-properties arenot.
> This leads to NPEs further down the line.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
